Files
UnheardCity/tests/test_game.py
Cristian Gora 1ccaa8b398 Full correctness check against the docs: safer writes, reverts and texts
Safety
- Writes are serialized (Workspace.lock): two background jobs rebuilding one
  package (a sound and its subtitle applied side by side) lost an edit.
- A store copies a bank file or package as "original" only if it matches the
  shipped catalog (Workspace.unoriginal_files: in-memory sounds, bank copies of
  voice lines, subtitles); the editor refuses to switch stores while changes
  are applied. A second store could otherwise resurrect a reverted sound.
- Mod import in the editor asks before overwriting files changed outside the
  tool (it forced silently).
- Revert all in the editor reverts texts too; the uninstaller counts text
  edits before offering to delete the store.
- ackit restore-backup: the full-backup restore decisions.md described; it
  keeps the sounds of WADs without a full copy recorded.
- build_catalog also stops when a subtitle differs from the catalog.

Languages and texts
- Game.language() returns languages without voices (JPN, RUS, ...) and
  Game.voice_archive() their INT voices; ackit text --lang JPN works.
- Menu lookups parse one cached file (find & replace: minutes -> ms).
- Subtitles decode cp1252 as Windows does: the UTF-8-in-cp1252 line
  Speech_TAPE_J_Answer_1_00 (KOR/POL/POR/RUS) is written back byte-for-byte;
  SUB_KOR/SUB_RUS rebuilt from the original game (only those rows changed).
- Mods exported while another language is loaded keep name and line.

Other fixes
- Down-mix folds extra channels in at -3 dB (a 5.1 centre voice was dropped).
- e2e_editor no longer overwrites the user's settings.json; kill_game waits
  for the game to exit before reverts.
- Recorder handles Int32/UInt8 input and split frames; package block cache
  locked; conflict messages, CLI help examples, stale docstrings and doc
  references fixed; tests no longer read this PC's game language.

Docs (decisions, user guide, README, subtitles.md, banks.md, catalog README,
REPORT, NOTES, CLAUDE.md) updated; check_docs: 102 claims match. 148 tests;
e2e_features 9/9, e2e_editor and verify PASS; game original afterwards.
2026-10-13 21:34:13 +02:00

63 lines
2.7 KiB
Python

"""Game discovery: Steam libraries on Linux (incl. extra libraries and Proton prefix language)."""
import os
import shutil
from ackit import game as G
def test_linux_steam_and_proton_discovery(synth_game, tmp_path, monkeypatch):
root, _ = synth_game
home = tmp_path / "home"
steam = home / ".local" / "share" / "Steam"
lib2 = tmp_path / "games" / "SteamLibrary"
(steam / "steamapps").mkdir(parents=True)
common = lib2 / "steamapps" / "common"
common.mkdir(parents=True)
gdir = common / "Batman Arkham City GOTY"
shutil.copytree(root, gdir)
# a second language so the ini choice is visible
loc = gdir / "BmGame" / "CookedPCConsole"
(loc / "French(France)").mkdir()
shutil.copy(loc / "English(US)" / "28CCF006_LOC_INT.wad", loc / "French(France)" / "134795B3_LOC_FRA.wad")
(steam / "steamapps" / "libraryfolders.vdf").write_text(
'"libraryfolders"\n{\n "0" { "path" "%s" }\n "1" { "path" "%s" }\n}\n' % (steam, lib2))
cfg = (lib2 / "steamapps" / "compatdata" / "200260" / "pfx" / "drive_c" / "users" / "steamuser" / "Documents" /
"WB Games" / "Batman Arkham City GOTY" / "BmGame" / "Config")
cfg.mkdir(parents=True)
(cfg / "UserEngine.ini").write_bytes("[Engine.Engine]\r\nLanguage=Fra\r\n".encode("utf-16"))
monkeypatch.setattr(G.sys, "platform", "linux")
monkeypatch.setattr(G.os.path, "expanduser", lambda p: p.replace("~", str(home)))
found = G.find_installs()
assert [os.path.normcase(f) for f in found] == [os.path.normcase(str(gdir))]
g = G.Game(found[0])
assert set(g.archives) == {"INT", "FRA", "SFX"}
assert g.language() == "FRA"
assert g.exe and g.exe.endswith("BatmanAC.exe")
def test_case_insensitive_paths(synth_game, tmp_path):
root, _ = synth_game
assert G._iglob_one(root, "bmgame", "cookedpcconsole")
assert G.Game(root).languages == ["INT"]
def test_not_a_game_folder(tmp_path):
import pytest
with pytest.raises(G.GameError):
G.Game(str(tmp_path))
def test_language_without_voices(synth_game, tmp_path, monkeypatch):
"""A game set to a language with texts only (e.g. JPN) is in that language, with the INT voices."""
root, _ = synth_game
os.makedirs(os.path.join(root, "BmGame", "Localization", "JPN"), exist_ok=True)
cfg = tmp_path / "cfg"
cfg.mkdir()
(cfg / "UserEngine.ini").write_bytes("[Engine.Engine]\r\nLanguage=Jpn\r\n".encode("utf-16"))
monkeypatch.setattr(G.Game, "config_dirs", lambda self: [str(cfg)])
g = G.Game(root)
assert g.language() == "JPN" and g.voice_archive(g.language()) == "INT"
from ackit.catalog import Catalog
assert "INT" in Catalog(g).archives # the default catalog loads the INT voices